Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): refer to https://console.shorebird.dev for account creation #1235

Conversation

nilsreichardt
Copy link
Contributor

Description

The CLI suggested using shorebird account create to create an account if no account could be found. However, since version 0.11.0, there is no shorebird account create anymore. I replaced shorebird account create with "https://console.shorebird.dev" to create an account.

Fixes #1234 (lol, nice ticket number)

(I don't know if this is the correct fix, feel free to close this PR)

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d326fab) 98.92% compared to head (ddf9433) 98.92%.

❗ Current head ddf9433 differs from pull request most recent head 44414fd. Consider uploading reports for the commit 44414fd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         179      179           
  Lines        4565     4565           
=======================================
  Hits         4516     4516           
  Misses         49       49           
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...orebird_cli/lib/src/commands/login_ci_command.dart 100.00% <100.00%> (ø)
...ges/shorebird_cli/lib/src/shorebird_validator.dart 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel changed the title fix(shorebird_cli): suggest to go to "https://console.shorebird.dev" to create an account fix(shorebird_cli): refer to https://console.shorebird.dev for account creation Sep 8, 2023
@felangel felangel merged commit f2ae6b4 into shorebirdtech:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: using shorebird login with an account that does not exist suggests to use shorebird account create
3 participants