Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codecov does not allow '/' in the name of coverage flags #1168

Merged
merged 7 commits into from
Aug 28, 2023

Conversation

eseidel
Copy link
Contributor

@eseidel eseidel commented Aug 25, 2023

So fixed by using a stack overflow answer of how to split a
path in GitHub actions. Now we only pass the package name
not the entire path.

Could consider moving this out of the action, and have the package
name be an input?

So fixed by using a stack overflow answer of how to split a
path in GitHub actions.  Now we only pass the package name
not the entire path.

Could consider moving this out of the action, and have the package
name be an input?
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.17% ⚠️

Comparison is base (a916d7d) 100.00% compared to head (fb6eb85) 97.83%.
Report is 4 commits behind head on main.

❗ Current head fb6eb85 differs from pull request most recent head fdf5211. Consider uploading reports for the commit fdf5211 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1168      +/-   ##
===========================================
- Coverage   100.00%   97.83%   -2.17%     
===========================================
  Files           81      179      +98     
  Lines         3181     4518    +1337     
===========================================
+ Hits          3181     4420    +1239     
- Misses           0       98      +98     
Flag Coverage Δ
artifact_proxy 100.00% <ø> (?)
cutler 14.03% <ø> (?)
discord_gcp_alerts 100.00% <ø> (?)
jwt 100.00% <ø> (?)
redis_client 100.00% <ø> (?)
scoped 100.00% <ø> (?)
shorebird_cli 100.00% <ø> (?)
shorebird_code_push_client 100.00% <ø> (?)
shorebird_code_push_protocol 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 98 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseidel
Copy link
Contributor Author

eseidel commented Aug 28, 2023

Landing as this is strictly better than what we have now on main. I will separately look into why cutler isn't being held to only 10%.

@eseidel eseidel merged commit 31b1df8 into main Aug 28, 2023
@eseidel eseidel deleted the fix_coverage_flags branch August 28, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants