test: rewrite cutler to be testable #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanoltman
approved these changes
Aug 25, 2023
I also shared some code between "versions" and "rebase"
I removed the 'rebase' command for now since it was dead. 'rebase' should be re-written later to just print the commands needed since having it actually drive the rebase was a dream. I separated "Repo" from "Checkout" and removed the global config object. I moved to using a global logger and package scoped to match other packages. I added a bunch of tests. This still doesn't have 100% coverage but it should be 100% testable now.
|
I ended up doing a massive rewrite of cutler. |
felangel
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the 'rebase' command for now since it was dead.
'rebase' should be re-written later to just print the commands
needed since having it actually drive the rebase was a dream.
I separated "Repo" from "Checkout" and removed the global config object.
I moved to using a global logger and package scoped to match
other packages.
I added a bunch of tests. This still doesn't have 100% coverage
but it should
be 100% testable now.