Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): use retrying logging http clients for patch commands #1143

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

This will allow us to get better insights into patch command failures and make the artifact downloading more robust.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (606438f) 100.00% compared to head (f49879a) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           81        81           
  Lines         3159      3159           
=========================================
  Hits          3159      3159           
Files Changed Coverage Δ
...ages/shorebird_cli/lib/src/patch_diff_checker.dart 100.00% <ø> (ø)
..._cli/lib/src/commands/patch/patch_aar_command.dart 100.00% <100.00%> (ø)
.../lib/src/commands/patch/patch_android_command.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit b73a57b into main Aug 23, 2023
@bryanoltman bryanoltman deleted the bo/logging-retry-client branch August 23, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants