feat(code_push_protocol): Add GetReleasePatchesResponse #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1094 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 87 165 +78
Lines 3328 4205 +877
==========================================
+ Hits 3328 4205 +877
☔ View full report in Codecov by Sentry. |
felangel
reviewed
Aug 14, 2023
| Json toJson() => _$GetReleasePatchesResponseToJson(this); | ||
|
|
||
| /// Patch numbers for a given release mapped to their artifacts. | ||
| final Map<int, List<PatchArtifact>> patches; |
There was a problem hiding this comment.
Does this need to be a Map? Couldn't this be a List<PatchArtifact> since the patchId is part of the artifact?
There was a problem hiding this comment.
The artifact doesn't know which patch number (not ID) it's related to, and I think we probably want to display patch numbers on the client.
There was a problem hiding this comment.
Ah yeah nvm I misread makes sense 👍
felangel
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will be used as a response type to
/api/v1/apps/$appId/releases/$releaseId/patches, which will allow clients to list patches and their artifacts for a given release.Part of #1095
Type of Change