Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): cache artifact download error handling #1087

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

felangel
Copy link
Contributor

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Aug 10, 2023
packages/shorebird_cli/lib/src/cache.dart Show resolved Hide resolved
Comment on lines +146 to +148
Failed to download $name: $error
If you're behind a firewall/proxy, please, make sure shorebird_cli is
allowed to access $storageUrl.''',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b1191ed) 100.00% compared to head (4b1a5c7) 100.00%.
Report is 3 commits behind head on main.

❗ Current head 4b1a5c7 differs from pull request most recent head d665c1e. Consider uploading reports for the commit d665c1e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1087   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines         3310      3319    +9     
=========================================
+ Hits          3310      3319    +9     
Files Changed Coverage Δ
packages/shorebird_cli/lib/src/cache.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit cb543a1 into main Aug 10, 2023
@felangel felangel deleted the fix/cache-network-errors branch August 10, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: invalid or corrupt bundletool
2 participants