Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shorebird_cli): ShorebirdFlutterValidator use ShorebirdFlutter #1076

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Aug 9, 2023

Description

  • refactor(shorebird_cli): ShorebirdFlutterValidator use ShorebirdFlutter
    • instead of using process directly

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6ac8492) 100.00% compared to head (f09a8a6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1076   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines         3263      3253   -10     
=========================================
- Hits          3263      3253   -10     
Files Changed Coverage Δ
...kages/shorebird_cli/lib/src/shorebird_flutter.dart 100.00% <100.00%> (ø)
...ib/src/validators/shorebird_flutter_validator.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit 97c5e55 into main Aug 9, 2023
@felangel felangel deleted the refactor/shorebird-flutter-validator branch August 9, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants