feat(shorebird_cli): add shorebird flutter version use
#1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 87 +1
Lines 3214 3244 +30
=========================================
+ Hits 3214 3244 +30
☔ View full report in Codecov by Sentry. |
bryanoltman
approved these changes
Aug 8, 2023
| if (!versions.contains(version)) { | ||
| logger.err(''' | ||
| Version $version not found. | ||
| Use `shorebird flutter versions list` to list available versions.'''); |
There was a problem hiding this comment.
What do you think about including a link to our feature request template to tell people they can request specific versions?
There was a problem hiding this comment.
Ah yeah great call! Will do in the next PR if that's cool 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shorebird flutter version use(closes feat: shorebird should support switching flutter versions #1037)change.shorebird.flutter.version.mp4
Type of Change