feat(artifact_proxy): add windows files (#2741)

shorebirdtech · Jan 7, 2025 · 7f38e8f · 7f38e8f
1 parent 839719a
commit 7f38e8f
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 25 deletions.
diff --git a/packages/artifact_proxy/test/artifact_proxy_test.dart b/packages/artifact_proxy/test/artifact_proxy_test.dart
@@ -131,31 +131,35 @@ void main() {
     });
 
     // artifact_proxy only runs on linux currently.
-    test('generate_manifest matches config', () async {
-      // Make a temp directory, run generate_manifest, parse the yaml
-      // and make sure all urls are handled.
-      const engineRevision = '8b89f8bd9fc6982aa9c4557fd0e5e89db1ff9986';
-      final result = Process.runSync('/bin/sh', [
-        'tool/generate_manifest.sh',
-        engineRevision,
-      ]);
-      expect(result.exitCode, equals(0));
-      final manifest = checkedYamlDecode(
-        result.stdout as String,
-        (m) => ArtifactsManifest.fromJson(m!),
-      );
-      expect(manifest.artifactOverrides, isNotEmpty);
-
-      for (final pattern in manifest.artifactOverrides) {
-        final path = pattern.replaceAll(r'$engine', engineRevision);
-        final request = buildRequest(path);
-        final response = await handler(request);
-        expect(
-          response.statusCode,
-          isNot(HttpStatus.notFound),
-          reason: 'Pattern $pattern not handled',
+    test(
+      'generate_manifest matches config',
+      () async {
+        // Make a temp directory, run generate_manifest, parse the yaml
+        // and make sure all urls are handled.
+        const engineRevision = '8b89f8bd9fc6982aa9c4557fd0e5e89db1ff9986';
+        final result = Process.runSync('/bin/sh', [
+          'tool/generate_manifest.sh',
+          engineRevision,
+        ]);
+        expect(result.exitCode, equals(0));
+        final manifest = checkedYamlDecode(
+          result.stdout as String,
+          (m) => ArtifactsManifest.fromJson(m!),
         );
-      }
-    });
+        expect(manifest.artifactOverrides, isNotEmpty);
+
+        for (final pattern in manifest.artifactOverrides) {
+          final path = pattern.replaceAll(r'$engine', engineRevision);
+          final request = buildRequest(path);
+          final response = await handler(request);
+          expect(
+            response.statusCode,
+            isNot(HttpStatus.notFound),
+            reason: 'Pattern $pattern not handled',
+          );
+        }
+      },
+      onPlatform: {'windows': const Skip('needs bash')},
+    );
   });
 }
diff --git a/packages/artifact_proxy/tool/generate_manifest.sh b/packages/artifact_proxy/tool/generate_manifest.sh
@@ -76,3 +76,7 @@ artifact_overrides:
   - flutter_infra_release/flutter/\$engine/darwin-x64-release/artifacts.zip
   - flutter_infra_release/flutter/\$engine/darwin-x64-release/framework.zip
   - flutter_infra_release/flutter/\$engine/darwin-x64-release/gen_snapshot.zip
+
+  # Windows release artifacts
+  - flutter_infra_release/flutter/\$engine/windows-x64/artifacts.zip
+  - flutter_infra_release/flutter/\$engine/windows-x64-release/windows-x64-flutter.zip