Skip to content

Commit

Permalink
fix(shorebird_cli): shorebird release ios warns on unknown shorebir…
Browse files Browse the repository at this point in the history
…d flutter versions (#1712)
  • Loading branch information
felangel authored Feb 7, 2024
1 parent 8989e29 commit 2b616c7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ class ShorebirdFlutterVersionSupportsIOSValidator extends Validator {
if (flutterVersion == null) {
issues.add(
const ValidationIssue(
severity: ValidationIssueSeverity.error,
message: 'Failed to determine Shorebird Flutter version',
severity: ValidationIssueSeverity.warning,
message: 'Unable to determine Shorebird Flutter version',
),
);
return issues;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ void main() {
when(() => shorebirdFlutter.getVersion()).thenAnswer((_) async => null);
});

test('returns validation error', () async {
test('returns validation warning', () async {
final results = await runWithOverrides(validator.validate);

expect(
results,
equals([
const ValidationIssue(
severity: ValidationIssueSeverity.error,
message: 'Failed to determine Shorebird Flutter version',
severity: ValidationIssueSeverity.warning,
message: 'Unable to determine Shorebird Flutter version',
),
]),
);
Expand Down

0 comments on commit 2b616c7

Please sign in to comment.