feat(discord_gcp_alerts): include policy name in alert title (#431)

shorebirdtech · May 3, 2023 · 1cb8154 · 1cb8154
1 parent a3a630f
commit 1cb8154
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/packages/discord_gcp_alerts/lib/src/gcp_alert_handler.dart b/packages/discord_gcp_alerts/lib/src/gcp_alert_handler.dart
@@ -18,10 +18,11 @@ Handler gcpAlertHandler({required String webhookUrl, http.Client? client}) {
     final url = incident?.url;
     final resource = incident?.resourceName;
     final conditionName = incident?.conditionName;
+    final policyName = incident?.policyName ?? 'GCP Alert';
     final discordPayload = {
       'embeds': [
         {
-          'title': 'GCP Alert',
+          'title': '🚨 $policyName 🚨',
           'description': summary,
           'url': url,
           'color': 0xFF0000,

diff --git a/packages/discord_gcp_alerts/lib/src/models/gcp_alert.dart b/packages/discord_gcp_alerts/lib/src/models/gcp_alert.dart
@@ -37,6 +37,7 @@ class Incident {
     this.summary,
     this.resourceName,
     this.conditionName,
+    this.policyName,
   });
 
   /// Creates an [Incident] from a JSON [Map].
@@ -52,6 +53,9 @@ class Incident {
   /// A summary of the incident.
   final String? summary;
 
+  /// The name of the policy associated with the incident.
+  final String? policyName;
+
   /// The name of the resource.
   final String? resourceName;
 

diff --git a/packages/discord_gcp_alerts/lib/src/models/gcp_alert.g.dart b/packages/discord_gcp_alerts/lib/src/models/gcp_alert.g.dart
diff --git a/packages/discord_gcp_alerts/test/src/gcp_alert_handler_test.dart b/packages/discord_gcp_alerts/test/src/gcp_alert_handler_test.dart
@@ -94,7 +94,7 @@ void main() {
           body: json.encode({
             'embeds': [
               {
-                'title': 'GCP Alert',
+                'title': '🚨 projects/12345/alertPolicies/12345 🚨',
                 'description': 'Test Incident',
                 'url': 'http://www.example.com',
                 'color': 16711680,