Skip to content
This repository has been archived by the owner on Feb 14, 2025. It is now read-only.

fix: send all application_library_path values to shorebird updater #6

Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix: send all application_library_path values to shorebird updater #6

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66f034c
fix: send all application_library_path values to updater
felangel Mar 30, 2023
5d8d6a7
free paths
felangel Mar 30, 2023
e4c3b17
use vector to avoid manual free
felangel Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions shell/platform/android/flutter_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ void ConfigureShorebird(std::string android_cache_path,

shorebird_init(&app_parameters, shorebirdYaml.c_str());

// shorebird_init() copies the paths, so we can free them now.
for (auto& path : original_libapp_paths) {
free((void*)path);
path = nullptr;
}

FML_LOG(INFO) << "Starting Shorebird update";
shorebird_update();

Expand Down