Merge pull request #34 from shopware/fix-theme-refresh-call

fix: theme refresh call, fixes #33
shopware · Dec 11, 2024 · 9cdcb79 · 9cdcb79
2 parents 0866ce6 + 4219da8
commit 9cdcb79
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/Services/UpgradeManager.php b/src/Services/UpgradeManager.php
@@ -61,7 +61,11 @@ public function run(RunConfiguration $configuration, OutputInterface $output): v
         }
 
         $this->processHelper->console(['plugin:refresh']);
-        $this->processHelper->console(['theme:refresh']);
+
+        if ($this->state->isStorefrontInstalled()) {
+            $this->processHelper->console(['theme:refresh']);
+        }
+
         $this->processHelper->console(['scheduled-task:register']);
         $this->processHelper->console(['messenger:setup-transports']);
 

diff --git a/tests/Services/UpgradeManagerTest.php b/tests/Services/UpgradeManagerTest.php
@@ -124,7 +124,7 @@ public function testRunUpdatesVersionNoAssetCompile(): void
 
         $manager->run(new RunConfiguration(true, true), $this->createMock(OutputInterface::class));
 
-        static::assertCount(5, $consoleCommands);
+        static::assertCount(4, $consoleCommands);
         static::assertSame(['system:update:finish', '--skip-asset-build'], $consoleCommands[0]);
     }
 
@@ -133,7 +133,7 @@ public function testRunWithDifferentSalesChannelUrl(): void
     {
         $state = $this->createMock(ShopwareState::class);
         $state
-            ->expects($this->once())
+            ->expects($this->exactly(2))
             ->method('isStorefrontInstalled')
             ->willReturn(true);
 
@@ -206,10 +206,10 @@ public function testRunWithMaintenanceMode(): void
 
         $manager->run(new RunConfiguration(), $this->createMock(OutputInterface::class));
 
-        static::assertCount(7, $consoleCommands);
+        static::assertCount(6, $consoleCommands);
         static::assertSame(['cache:pool:clear', 'cache.http', 'cache.object'], $consoleCommands[0]);
         static::assertArrayHasKey(5, $consoleCommands);
-        static::assertSame(['cache:pool:clear', 'cache.http', 'cache.object'], $consoleCommands[6]);
+        static::assertSame(['cache:pool:clear', 'cache.http', 'cache.object'], $consoleCommands[5]);
     }
 
     public function testRunWithLicenseDomain(): void