mod: update version of goveralls. #521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes involve updates to multiple files, including the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
713e0a0 to
47822d9
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
lib/runner.js (3)
1-1: Remove redundant 'use strict' directiveThe
'use strict'directive is unnecessary in ES6 modules since they are in strict mode by default. Consider removing it to clean up the code.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
70-103: Refactor duplicated code inrunandfinishfunctionsThe
runandfinishfunctions share similar logic for setting up environment variables and arguments before executing thegoverallscommand. Refactoring this shared logic into separate helper functions would improve maintainability and reduce code duplication.You can apply the following refactor to extract common code:
+async function goverallsExecute(options, isFinish) { + const env = { + COVERALLS_TOKEN: options.token, + }; + for (const name of go_environment_values) { + const value = process.env[name] || (name.match(/^GO/) && (await go_env(name))); + if (value) { + env[name] = value; + } + } + + const args = isFinish ? ["-parallel-finish", "-service=github"] : ["-service=github"]; + if (options.profile && !isFinish) { + args.push(`-coverprofile=${options.profile}`); + } + if (options.ignore) { + args.push(`-ignore=${options.ignore}`); + } + if (options.parallel && !isFinish) { + args.push("-parallel"); + if (options.flag_name !== "") { + args.push(`-flagname=${options.flag_name}`); + } + } + if (options.shallow) { + args.push("-shallow"); + } + if (core.isDebug()) { + args.push("-debug"); + } + + await exec.exec(get_goveralls_path(), args, { + env: env, + cwd: options.working_directory, + }); +} async function run(options) { - const env = { - COVERALLS_TOKEN: options.token, - }; - // [existing code to set up env and args] - await exec.exec(get_goveralls_path(), args, { - env: env, - cwd: options.working_directory, - }); + await goverallsExecute(options, false); } async function finish(options) { - const env = { - COVERALLS_TOKEN: options.token, - }; - // [existing code to set up env and args] - await exec.exec(get_goveralls_path(), args, { - env: env, - cwd: options.working_directory, - }); + await goverallsExecute(options, true); }Also applies to: 104-128
149-178: Extend architecture support inget_goveralls_pathfunctionCurrently, the
get_goveralls_pathfunction supports only'x64'and'arm64'architectures. Consider adding support for additional architectures like'ia32'or'arm'to enhance compatibility.You can modify the architecture switch case as follows:
switch (process.arch) { case "x64": arch = "amd64"; break; case "arm64": arch = "arm64"; break; + case "ia32": + arch = "386"; + break; + case "arm": + arch = "arm"; + break; default: throw new Error(`unsupported architecture: ${process.arch}`); }lib/main.js (1)
1-1: Remove redundant 'use strict' directiveThe
'use strict'directive is unnecessary in ES6 modules since they are in strict mode by default. Removing it will simplify the code.🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (135)
bin/goveralls_windows_amd64.exeis excluded by!**/*.exebin/goveralls_windows_arm64.exeis excluded by!**/*.exego.sumis excluded by!**/*.sumnode_modules/@actions/core/LICENSE.mdis excluded by!**/node_modules/**node_modules/@actions/core/README.mdis excluded by!**/node_modules/**node_modules/@actions/core/lib/command.d.tsis excluded by!**/node_modules/**node_modules/@actions/core/lib/command.jsis excluded by!**/node_modules/**node_modules/@actions/core/lib/command.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/core/lib/core.d.tsis excluded by!**/node_modules/**node_modules/@actions/core/lib/core.jsis excluded by!**/node_modules/**node_modules/@actions/core/lib/core.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/core/lib/file-command.d.tsis excluded by!**/node_modules/**node_modules/@actions/core/lib/file-command.jsis excluded by!**/node_modules/**node_modules/@actions/core/lib/file-command.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/core/lib/oidc-utils.d.tsis excluded by!**/node_modules/**node_modules/@actions/core/lib/oidc-utils.jsis excluded by!**/node_modules/**node_modules/@actions/core/lib/oidc-utils.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/core/lib/path-utils.d.tsis excluded by!**/node_modules/**node_modules/@actions/core/lib/path-utils.jsis excluded by!**/node_modules/**node_modules/@actions/core/lib/path-utils.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/core/lib/summary.d.tsis excluded by!**/node_modules/**node_modules/@actions/core/lib/summary.jsis excluded by!**/node_modules/**node_modules/@actions/core/lib/summary.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/core/lib/utils.d.tsis excluded by!**/node_modules/**node_modules/@actions/core/lib/utils.jsis excluded by!**/node_modules/**node_modules/@actions/core/lib/utils.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/core/package.jsonis excluded by!**/node_modules/**node_modules/@actions/exec/LICENSE.mdis excluded by!**/node_modules/**node_modules/@actions/exec/README.mdis excluded by!**/node_modules/**node_modules/@actions/exec/lib/exec.d.tsis excluded by!**/node_modules/**node_modules/@actions/exec/lib/exec.jsis excluded by!**/node_modules/**node_modules/@actions/exec/lib/exec.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/exec/lib/interfaces.d.tsis excluded by!**/node_modules/**node_modules/@actions/exec/lib/interfaces.jsis excluded by!**/node_modules/**node_modules/@actions/exec/lib/interfaces.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/exec/lib/toolrunner.d.tsis excluded by!**/node_modules/**node_modules/@actions/exec/lib/toolrunner.jsis excluded by!**/node_modules/**node_modules/@actions/exec/lib/toolrunner.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/exec/package.jsonis excluded by!**/node_modules/**node_modules/@actions/http-client/LICENSEis excluded by!**/node_modules/**node_modules/@actions/http-client/README.mdis excluded by!**/node_modules/**node_modules/@actions/http-client/lib/auth.d.tsis excluded by!**/node_modules/**node_modules/@actions/http-client/lib/auth.jsis excluded by!**/node_modules/**node_modules/@actions/http-client/lib/auth.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/http-client/lib/index.d.tsis excluded by!**/node_modules/**node_modules/@actions/http-client/lib/index.jsis excluded by!**/node_modules/**node_modules/@actions/http-client/lib/index.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/http-client/lib/interfaces.d.tsis excluded by!**/node_modules/**node_modules/@actions/http-client/lib/interfaces.jsis excluded by!**/node_modules/**node_modules/@actions/http-client/lib/interfaces.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/http-client/lib/proxy.d.tsis excluded by!**/node_modules/**node_modules/@actions/http-client/lib/proxy.jsis excluded by!**/node_modules/**node_modules/@actions/http-client/lib/proxy.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/http-client/package.jsonis excluded by!**/node_modules/**node_modules/@actions/io/README.mdis excluded by!**/node_modules/**node_modules/@actions/io/lib/io-util.d.tsis excluded by!**/node_modules/**node_modules/@actions/io/lib/io-util.jsis excluded by!**/node_modules/**node_modules/@actions/io/lib/io-util.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/io/lib/io.d.tsis excluded by!**/node_modules/**node_modules/@actions/io/lib/io.jsis excluded by!**/node_modules/**node_modules/@actions/io/lib/io.js.mapis excluded by!**/node_modules/**,!**/*.mapnode_modules/@actions/io/package.jsonis excluded by!**/node_modules/**node_modules/tunnel/CHANGELOG.mdis excluded by!**/node_modules/**node_modules/tunnel/LICENSEis excluded by!**/node_modules/**node_modules/tunnel/README.mdis excluded by!**/node_modules/**node_modules/tunnel/index.jsis excluded by!**/node_modules/**node_modules/tunnel/lib/tunnel.jsis excluded by!**/node_modules/**node_modules/tunnel/package.jsonis excluded by!**/node_modules/**node_modules/uuid/CHANGELOG.mdis excluded by!**/node_modules/**node_modules/uuid/CONTRIBUTING.mdis excluded by!**/node_modules/**node_modules/uuid/LICENSE.mdis excluded by!**/node_modules/**node_modules/uuid/README.mdis excluded by!**/node_modules/**node_modules/uuid/dist/bin/uuidis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/index.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/md5.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/nil.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/parse.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/regex.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/rng.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/sha1.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/stringify.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/v1.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/v3.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/v35.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/v4.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/v5.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/validate.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-browser/version.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/index.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/md5.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/nil.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/parse.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/regex.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/rng.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/sha1.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/stringify.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/v1.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/v3.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/v35.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/v4.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/v5.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/validate.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/esm-node/version.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/index.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/md5-browser.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/md5.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/nil.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/parse.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/regex.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/rng-browser.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/rng.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/sha1-browser.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/sha1.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/stringify.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/umd/uuid.min.jsis excluded by!**/dist/**,!**/node_modules/**,!**/*.min.jsnode_modules/uuid/dist/umd/uuidNIL.min.jsis excluded by!**/dist/**,!**/node_modules/**,!**/*.min.jsnode_modules/uuid/dist/umd/uuidParse.min.jsis excluded by!**/dist/**,!**/node_modules/**,!**/*.min.jsnode_modules/uuid/dist/umd/uuidStringify.min.jsis excluded by!**/dist/**,!**/node_modules/**,!**/*.min.jsnode_modules/uuid/dist/umd/uuidValidate.min.jsis excluded by!**/dist/**,!**/node_modules/**,!**/*.min.jsnode_modules/uuid/dist/umd/uuidVersion.min.jsis excluded by!**/dist/**,!**/node_modules/**,!**/*.min.jsnode_modules/uuid/dist/umd/uuidv1.min.jsis excluded by!**/dist/**,!**/node_modules/**,!**/*.min.jsnode_modules/uuid/dist/umd/uuidv3.min.jsis excluded by!**/dist/**,!**/node_modules/**,!**/*.min.jsnode_modules/uuid/dist/umd/uuidv4.min.jsis excluded by!**/dist/**,!**/node_modules/**,!**/*.min.jsnode_modules/uuid/dist/umd/uuidv5.min.jsis excluded by!**/dist/**,!**/node_modules/**,!**/*.min.jsnode_modules/uuid/dist/uuid-bin.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/v1.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/v3.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/v35.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/v4.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/v5.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/validate.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/dist/version.jsis excluded by!**/dist/**,!**/node_modules/**node_modules/uuid/package.jsonis excluded by!**/node_modules/**node_modules/uuid/wrapper.mjsis excluded by!**/node_modules/**package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
.gitignore(0 hunks)go.mod(1 hunks)lib/main.js(1 hunks)lib/runner.js(1 hunks)package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .gitignore
✅ Files skipped from review due to trivial changes (1)
- package.json
🚧 Files skipped from review as they are similar to previous changes (1)
- go.mod
🧰 Additional context used
🪛 Biome (1.9.4)
lib/main.js
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
[error] 19-19: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
lib/runner.js
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
[error] 19-19: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
🔇 Additional comments (1)
lib/main.js (1)
26-49: Proper error handling in the run function
The run function correctly handles errors by checking if the caught error is an instance of Error and uses core.setFailed to report it. This is a good practice for robust error handling in GitHub Actions.
47822d9 to
c440f43
Compare
ziggie1984
added a commit
to ziggie1984/lnd
that referenced
this pull request
Dec 12, 2024
The goverall tool had a bug regarding the module versioning of golang packages see also mattn/goveralls#222 for more background. Goveralls is wrapped by another library to make it available for github actions. So the relevant PR which is referenced here in LND is: shogo82148/actions-goveralls#521.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
goverallscommand in a CI/CD environment with enhanced error handling.Chores
.gitignorefor better version control tracking.Version Update
0.0.0to1.9.0.