Fix swagger-api#1305

shockey · Apr 28, 2017 · 004201b · 004201b
1 parent 84b77c2
commit 004201b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/plugins/validation/semantic-validators/validators/walker.js b/src/plugins/validation/semantic-validators/validators/walker.js
@@ -88,9 +88,9 @@ export function validate({ jsSpec }) {
       ///// $ref siblings
       return keys.map(k => {
         if(keys.indexOf("$ref") > -1 && k !== "$ref") {
-          errors.push({
+          warnings.push({
             path: path.concat([k]),
-            message: "Sibling values are not allowed alongside a $ref."
+            message: "Values alongside a $ref will be ignored."
           })
         }
         return walk(value[k], [...path, k])

diff --git a/test/plugins/validation/semantic/walker.js b/test/plugins/validation/semantic/walker.js
@@ -367,7 +367,7 @@ describe("validation plugin - semantic - spec walker", () => {
 
     describe("Ref siblings", () => {
 
-      it("should return an error when another property is a sibling of a $ref", () => {
+      it("should return a warning when another property is a sibling of a $ref", () => {
         const spec = {
           paths: {
             "/CoolPath/{id}": {
@@ -380,9 +380,9 @@ describe("validation plugin - semantic - spec walker", () => {
         }
 
         let res = validate({ jsSpec: spec })
-        expect(res.errors.length).toEqual(1)
-        expect(res.errors[0].path).toEqual(["paths", "/CoolPath/{id}", "schema", "description"])
-        expect(res.warnings.length).toEqual(0)
+        expect(res.errors.length).toEqual(0)
+        expect(res.warnings.length).toEqual(1)
+        expect(res.warnings[0].path).toEqual(["paths", "/CoolPath/{id}", "schema", "description"])
       })
 
     })