Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deprecated github actions #114

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

CrockAgile
Copy link
Collaborator

Github actions has started giving warnings that some actions in use are out of date. Let's see if updating these actions fixes the warnings!

@CrockAgile CrockAgile requested a review from shnewto November 30, 2022 17:01
@CrockAgile CrockAgile self-assigned this Nov 30, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.873% when pulling a8a638c on update-deprecated-actions into 3aa208e on main.

@CrockAgile
Copy link
Collaborator Author

Okay so turns out no, does not fix deprecation warnings. It looks like actions-rs has not fixed the issue (actions-rs/toolchain#221).

To be clear, it is okay they are not fixing it right away! Open source does not mean they owe us their time. But seems like we may need to look for alternatives.

In the mean time, I will still merge this since it had a passing coverage.

@CrockAgile CrockAgile merged commit b0a53db into main Nov 30, 2022
@CrockAgile CrockAgile deleted the update-deprecated-actions branch November 30, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants