Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce number of executed jobs #1799

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

mmorel-35
Copy link
Contributor

Description

Reduce the number of executed jobs by two ways

  • jobs are triggers on push on master only or on pull requests
  • with the concurrency configuration the jobs of a same PR get canceled if there is a more recent commit happening

It also sort fields and indent arrays in workflows

@mmorel-35 mmorel-35 force-pushed the worflows-concurrency branch 2 times, most recently from 1fb4d1a to 52a525c Compare February 25, 2025 06:23
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Mar 3, 2025

@shirou,
Would you mind having a look whenever you can find the time ?

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the worflows-concurrency branch from 52a525c to f04c791 Compare March 3, 2025 20:17
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Since you were still pushing changes, I wasn’t sure when to start the review. It would be helpful if you could set the PR to draft status until it’s ready for review or use the review request feature.

That aside, adding concurrency is definitely a good idea. I also appreciate the other small fixes you made.

@shirou shirou merged commit b7c02ad into shirou:master Mar 4, 2025
48 checks passed
@mmorel-35 mmorel-35 deleted the worflows-concurrency branch March 4, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants