Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixin calls #4

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Fix mixin calls #4

merged 1 commit into from
Apr 18, 2018

Conversation

jzelez
Copy link

@jzelez jzelez commented Apr 18, 2018

No description provided.

@shirohana
Copy link
Owner

Omg how a stupid mistake I made ｡ﾟヽ(ﾟ´Д`)ﾉﾟ｡

Is there any tool to help to lint my .styl codes (´；ω；｀)？

Thanks for your contribution ฅ' ω 'ฅ

@shirohana
Copy link
Owner

I'll publish a patch version to NPM like 0.7.0-patch.1

@shirohana shirohana merged commit f76f2fd into shirohana:dev Apr 18, 2018
@jzelez
Copy link
Author

jzelez commented Apr 18, 2018 •
edited
Loading

There is stylint but I don't think it would catch the above issue.

@shirohana
Copy link
Owner

That was so sad (´-ωก`)

I can find the mixins which was no parentheses after by the silver searcher, but it is not strict and it will make contributing more difficult...

Maybe I should add contribution guide section in README and notice myself to avoid making this trouble again (˘̩̩̩ ω ˘̩ƪ)

@shirohana
Copy link
Owner

After a time of code reviewing, 0.7.0-patch.1 available on NPM now ฅ' ω 'ฅ

https://github.com/shirohana/bulma.stylus/releases/tag/v0.7.0-patch.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzelez @shirohana