Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local Source Upload Doc. #91

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Local Source Upload Doc. #91

merged 1 commit into from
Jan 28, 2022

Conversation

otaviof
Copy link
Member

@otaviof otaviof commented Jan 25, 2022 •
edited
Loading

Changes

Initial documentation for the local source upload feature (#86).

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@otaviof otaviof added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 25, 2022
@openshift-ci openshift-ci bot requested review from alicerum and sbose78 January 25, 2022 09:14
@otaviof
Copy link
Member Author

otaviof commented Jan 25, 2022

/assign @rolfedh @adambkaplan

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@otaviof: GitHub didn't allow me to assign the following users: rolfedh.

Note that only shipwright-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @rolfedh @adambkaplan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rolfedh
rolfedh reviewed Jan 27, 2022
View reviewed changes
docs/local_source_upload.md Outdated
--output-image="docker.io/<namespace>/sample-nodejs:<tag>"
```

4. Rinse and repeat the previous step
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the suggested updates to step 3, maybe we can delete this step.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed.

@otaviof @rolfedh
Local Source Upload Documentation.
6c0da9c 
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
@otaviof otaviof force-pushed the build-26-upload-doc branch from b705c33 to 6c0da9c Compare January 27, 2022 15:42
@otaviof
Copy link
Member Author

otaviof commented Jan 27, 2022 •
edited
Loading

@rolfedh I've made some minor changes based on yours, please consider.

@rolfedh
Copy link
Contributor

rolfedh commented Jan 27, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@rolfedh: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@otaviof
Copy link
Member Author

otaviof commented Jan 27, 2022

/assign @HeavyWombat @adambkaplan

adambkaplan
adambkaplan approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
HeavyWombat
HeavyWombat approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit c4c0056 into shipwright-io:main Jan 28, 2022
@otaviof otaviof deleted the build-26-upload-doc branch January 28, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh approved these changes

@adambkaplan adambkaplan adambkaplan approved these changes

@HeavyWombat HeavyWombat HeavyWombat approved these changes

@alicerum alicerum Awaiting requested review from alicerum

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@adambkaplan adambkaplan

@HeavyWombat HeavyWombat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@otaviof @rolfedh @adambkaplan @HeavyWombat @openshift-merge-robot