Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial fix for issue 486 #487

Closed
wants to merge 1 commit into from
Closed

Partial fix for issue 486 #487

wants to merge 1 commit into from

Conversation

qu1queee
Copy link
Contributor

This forces our samples to use the main branch from
https://github.com/cloudfoundry/cf-acceptance-tests , the master
branch was deprecated. Thanks @zhangtbj for reporting this.

@qu1queee
Partial fix for issue 486
92f5fa5 
This forces our samples to use the `main` branch from
https://github.com/cloudfoundry/cf-acceptance-tests , the master
branch was deprecated
@qu1queee qu1queee requested review from zhangtbj and removed request for gabemontero and SaschaSchwarze0 November 18, 2020 13:33
@zhangtbj
Copy link
Contributor

Thanks for the quick fix.

As we know, there are just four test build yaml changes: Add the main revision for the 4 CF buildpack build yaml.

But the Travis failed at operator-sdk installation, I cannot restart the Travis here.

I suggest we accept this change first because NOW it blocks both our internal Travis/pipeline and Shipwright Travis.

We will verify the e2e test by using our internal Travis first soon. Will let all know if there is any other further problem.

zhangtbj
zhangtbj approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@zhangtbj zhangtbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangtbj
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangtbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@zhangtbj
Copy link
Contributor

/retest

@zhangtbj
Copy link
Contributor

/test all

@zhangtbj zhangtbj mentioned this pull request Nov 19, 2020
Merged
@zhangtbj
Copy link
Contributor

zhangtbj commented Nov 19, 2020 •
edited
Loading

Sorry @qu1queee ,

This PR cannot be merged because the Travis fail.

I opened a new PR (Already merged) to re-run the Travis again: #488

Please help to close this one. Thanks!

@zhangtbj zhangtbj closed this Nov 19, 2020
@qu1queee qu1queee deleted the qu1queee/change_test_to_main branch February 15, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangtbj zhangtbj zhangtbj approved these changes

Assignees

@zhangtbj zhangtbj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qu1queee @zhangtbj @openshift-ci-robot