Early exit Eventually block if target condition cannot be reached any more

[SaschaSchwarze0]

In the e2e tests, we have an Eventually block in validators.go which waits for a build run to be succeeded (and another one waits for it to be failed). We at the moment have no early exit in there. This means that a failed build run will cause the full timeout duration to be taken. As this is quite long and can be made even longer using the timeout multiplier, test timeouts can occur. We are seeing a Ginkgo node timeout for time to time in our regular tests:

	 -------------------------------------------------------------------
	|                                                                   |
	|  Ginkgo timed out waiting for all parallel nodes to report back!  |
	|                                                                   |
	 -------------------------------------------------------------------

I am adding early-exit conditions to break out of the Eventually loop.

[qu1queee]

looks good, in theory for validateBuildRunToSucceedwe will be asserting until we get the True(good case) or the false(bad case), and if we get an Unknown, then we continue polling.

[qu1queee]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qu1queee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment