Fixes to code generators #435
Conversation
- Moved boilerplate headers to external files
- Update-codegen.sh improvements:
- Add header argument to update-codegen.sh - required for k8s 1.18
- Ensure GOPATH is set - required for k8s 1.18
- Use script root instead of git root, make code-gen path relative to
script root
- generate-fakes improvements
- Call counterfieter from GOPATH
- Add header text from boilerplate
- Add generate Makefile target to create client, deepcopies, fakes, and
copyright. Updated travis to install counterfeiter and verify generated
code.
- Update docs/development/testing.md to inform contributors of the verification
step in Travis.
Update generated code with corrected copyrights.
There was a problem hiding this comment.
/lgtm
Is fine I think, but a lot changes. So waiting for a second pair of eyes to take a look. @zhangtbj can you have a look ?
|
@adambkaplan can you please check the tagging automation? I only said that it looked fine. Somehow, the |
|
@SaschaSchwarze0 I can check. It might be because you are an approver in the OWNERS file, an |
|
@zhangtbj can u take a look on this later this week? |
|
Document and script changes look good to me. No code logic change. Approve to unblock the work. Thanks! /approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0, zhangtbj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
script root
copyright. Updated travis to install counterfeiter and verify generated
code.
step in Travis.
make generateto add fixed copyright.I found these updates to be a prerequisite for bumping operator-sdk (#431) and k8s (#284 ).