Make build operator leader durations configurable #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
requested changes
Oct 7, 2020
There was a problem hiding this comment.
Nice work. Requesting two additions:
- a unit test where
BUILD_OPERATOR_LEADER_ELECTION_NAMESPACEis set - documentation for the environment variables, maybe just add a new file within the docs folder about the manager configuration; we will need to link this from somewhere then separately (the metrics.md is currently also not referenced from anywhere which we will also need to fix)
|
A comment:
|
In case the build operator needs to be started with very specific leader lease duration configuration, there is currently no way to configure it. Introduce new section in build configuration that contains some of the manager options to be configurable and passed through to the manager. Pass new section values as-is into the manager options for the build operator setup. Any `nil` value will result in the default value. Add four new environment variables to override these settings: - `BUILD_OPERATOR_LEADER_ELECTION_NAMESPACE` - `BUILD_OPERATOR_LEASE_DURATION` - `BUILD_OPERATOR_RENEW_DEADLINE` - `BUILD_OPERATOR_RETRY_PERIOD` Hint: All duration based environment variables use the time duration parse function, so they expect an input like `42s`.
In order to make it more readable and distinguishable, rename `c` to a name that is more descriptive: `buildCfg`.
The current namespace of the build-operator lock configmap is hard-coded to be `default` at the moment. With the new override possibilities, it can be set to a more suitable location. Use downward API to set `BUILD_OPERATOR_LEADER_ELECTION_NAMESPACE` environment variable in the deployment YAML for the build-operator to be the same namespace as the operator pod is located in.
Add new configuration documentation to explain the possible overrides of the build-operator using environment variables.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the build operator needs to be started with very specific leader
lease duration configuration, there is currently no way to configure it.
Introduce new section in build configuration that contains some of the
manager options to be configurable and passed through to the manager.
Pass new section values as-is into the manager options for the build
operator setup. Any
nilvalue will result in the default value.Add four new environment variables to override these settings:
BUILD_OPERATOR_LEADER_ELECTION_NAMESPACEBUILD_OPERATOR_LEASE_DURATIONBUILD_OPERATOR_RENEW_DEADLINEBUILD_OPERATOR_RETRY_PERIODPlease note: All duration based environment variables use the time duration
parse function, so they expect an input like
42s.This should fix #414.