Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to tekton v0.14.2 #312

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Upgrade to tekton v0.14.2 #312

merged 3 commits into from
Jul 28, 2020

Conversation

sbose78
Copy link
Member

@sbose78 sbose78 commented Jul 27, 2020 •
edited
Loading

Let's see how this works out..

fixes #221

@sbose78 sbose78 changed the title upgrade to tekton v0.14.2 Upgrade to tekton v0.14.2 Jul 27, 2020
@qu1queee
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 27, 2020
SaschaSchwarze0
SaschaSchwarze0 requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update as well:

@sbose78 sbose78 mentioned this pull request Jul 27, 2020
Closed
@SaschaSchwarze0
Copy link
Member

Hi @sbose78, the installation now looks good. Do you plan to update the README as well. It is mentioning the old supported Tekton version two times.

@qu1queee
Copy link
Contributor

I´m testing this now :)

@qu1queee
Copy link
Contributor

@sbose78 this looks great, I tested it locally with some Builds. I opened a PR to this PR branch, see sbose78#2 , it fixes what @SaschaSchwarze0 mentioned above.

qu1queee
qu1queee approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@sbose78
Copy link
Member Author

sbose78 commented Jul 28, 2020

Thanks! I thought I had updated the readme, my bad :-)

@qu1queee
Copy link
Contributor

I know @SaschaSchwarze0 is fine with this PR, although he haven´t yet approved.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@qu1queee
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 05feaae into shipwright-io:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 requested changes

@qu1queee qu1queee qu1queee approved these changes

@otaviof otaviof Awaiting requested review from otaviof

@gabemontero gabemontero Awaiting requested review from gabemontero

@zhangtbj zhangtbj Awaiting requested review from zhangtbj

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade the Tekton version to the latest v0.12 version
5 participants
@sbose78 @qu1queee @SaschaSchwarze0 @openshift-ci-robot @openshift-merge-robot