Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude RoleBinding from sample-strategies.yaml #1823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SaschaSchwarze0
Copy link
Member

Changes

For the multiarch buildstrategy, https://github.com/shipwright-io/build/tree/main/samples/v1beta1/buildstrategy/multiarch-native-buildah, we are delivering also a ClusterRole and RoleBindings so that the running build has the necessary permissions to manage Jobs and Pods in the cluster.

As described in https://github.com/shipwright-io/build/blob/main/docs/buildstrategies.md#installing-multi-arch-native-buildah-strategy, the RoleBinding must be installed in the namespace(s) where the build strategy will be used. As we cannot know which namespaces those are, we should not include this file in our sample-strategies.yaml.

This PR excludes it like we already also exclude our sample namespaces build strategies.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The role bindings related to the multiarch-native-buildah cluster build strategy sample are now not anymore included in our sample-strategies.yaml file. You must manually apply them to the namespaces where you plan to use this strategy.

Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
@SaschaSchwarze0 SaschaSchwarze0 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 3, 2025
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.16.0 milestone Mar 3, 2025
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Mar 3, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2025
Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from saschaschwarze0. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qu1queee qu1queee requested review from qu1queee and removed request for apoorvajagtap and karanibm6 March 4, 2025 05:23
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants