Add Custom Scheduler Name to Build and BuildRun objects #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind feature |
213215f to
02dfeeb
Compare
1997d43 to
47478bc
Compare
168706d to
8dca9b7
Compare
bf67139 to
95cf628
Compare
95cf628 to
3569430
Compare
4 tasks
3569430 to
d272428
Compare
d272428 to
7377fd4
Compare
734e205 to
7c64e81
Compare
|
Ok, this is ready for review. I relied on unit tests instead of creating a custom scheduler for testing, as was mentioned in https://github.com/shipwright-io/community/blob/main/ships/0039-build-scheduler-opts.md#test-plan. I also included the suggestions in the comments from #1711 in this PR. |
7c64e81 to
3a8ba74
Compare
SaschaSchwarze0
requested changes
Feb 20, 2025
Signed-off-by: Dylan Orzel <dorzel@redhat.com>
3a8ba74 to
8a4b647
Compare
Signed-off-by: Dylan Orzel <dorzel@redhat.com>
33d10f5 to
fae087f
Compare
SaschaSchwarze0
requested changes
Feb 20, 2025
|
|
||
| tr, err := tb.GetTaskRunFromBuildRun(buildRunObject.Name) | ||
| Expect(err).To(BeNil()) | ||
| Expect(*buildObject.Spec.SchedulerName).To(Equal(tr.Spec.PodTemplate.SchedulerName)) |
There was a problem hiding this comment.
I think we should turn that around.
Suggested change
| Expect(*buildObject.Spec.SchedulerName).To(Equal(tr.Spec.PodTemplate.SchedulerName)) | |
| Expect(tr.Spec.PodTemplate.SchedulerName).To(Equal(*buildObject.Spec.SchedulerName)) |
|
|
||
| tr, err := tb.GetTaskRunFromBuildRun(buildRunObject.Name) | ||
| Expect(err).To(BeNil()) | ||
| Expect(*br.Spec.SchedulerName).To(Equal(tr.Spec.PodTemplate.SchedulerName)) |
There was a problem hiding this comment.
Suggested change
| Expect(*br.Spec.SchedulerName).To(Equal(tr.Spec.PodTemplate.SchedulerName)) | |
| Expect(tr.Spec.PodTemplate.SchedulerName).To(Equal(*br.Spec.SchedulerName)) |
Signed-off-by: Dylan Orzel <dorzel@redhat.com>
fae087f to
6d2e8bf
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1637
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes