Move ko-related artifacts to ko-build #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rolfedh fyi contains small doc fixes, just links though |
5437633 to
47eb183
Compare
imjasonh
reviewed
Sep 8, 2022
| @@ -110,7 +110,7 @@ spec: | |||
| # Determine the ko version | |||
| KO_VERSION="${PARAM_KO_VERSION}" | |||
| if [ "${KO_VERSION}" == "latest" ]; then | |||
| KO_VERSION=$(curl --silent "https://api.github.com/repos/google/ko/releases/latest" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/') | |||
| KO_VERSION=$(curl --silent "https://api.github.com/repos/ko-build/ko/releases/latest" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/') | |||
There was a problem hiding this comment.
FYI you can add --location here too to follow redirects in case it moves again, but we have no plans to move again. I might update setup-ko to do this in the future, but it's not a high priority.
There was a problem hiding this comment.
Thought about it. But same thinking. I don't assume you will move again soon.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The ko project moved from the google to the ko-build organization. Adopting Shipwright.
The current ko build strategy is broken because
curl --silent "https://api.github.com/repos/google/ko/releases/latest"now causes a redirect to happen and therefore usinglatestdoes not work anymore with our build strategy. Specifying the release still worked because the download curl command always included-L(follow redirects) because GitHub imo always redirects them.Submitter Checklist
Release Notes