forked from desktop/desktop
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move icons to correct location, update usages in tooling #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
force-pushed
the
move-icons-to-correct-directory
branch
from
October 3, 2021 21:25
fa8f82c
to
9543083
Compare
shiftkey
added a commit
that referenced
this pull request
Oct 3, 2021
shiftkey
added a commit
that referenced
this pull request
Oct 7, 2021
shiftkey
added a commit
that referenced
this pull request
Oct 15, 2021
shiftkey
added a commit
that referenced
this pull request
Oct 22, 2021
shiftkey
added a commit
that referenced
this pull request
Oct 22, 2021
shiftkey
added a commit
that referenced
this pull request
Oct 22, 2021
shiftkey
added a commit
that referenced
this pull request
Nov 4, 2021
shiftkey
added a commit
that referenced
this pull request
Nov 4, 2021
shiftkey
added a commit
that referenced
this pull request
Nov 27, 2021
shiftkey
added a commit
that referenced
this pull request
Dec 18, 2021
shiftkey
added a commit
that referenced
this pull request
Dec 18, 2021
shiftkey
added a commit
that referenced
this pull request
Dec 18, 2021
shiftkey
added a commit
that referenced
this pull request
Dec 18, 2021
shiftkey
added a commit
that referenced
this pull request
Dec 18, 2021
shiftkey
added a commit
that referenced
this pull request
Feb 5, 2022
shiftkey
added a commit
that referenced
this pull request
Feb 22, 2022
shiftkey
added a commit
that referenced
this pull request
Feb 22, 2022
shiftkey
added a commit
that referenced
this pull request
Feb 22, 2022
shiftkey
added a commit
that referenced
this pull request
Feb 22, 2022
shiftkey
added a commit
that referenced
this pull request
Feb 22, 2022
shiftkey
added a commit
that referenced
this pull request
Feb 22, 2022
shiftkey
added a commit
that referenced
this pull request
Feb 22, 2022
shiftkey
added a commit
that referenced
this pull request
Feb 22, 2022
shiftkey
added a commit
that referenced
this pull request
Mar 12, 2022
shiftkey
added a commit
that referenced
this pull request
Apr 3, 2022
shiftkey
added a commit
that referenced
this pull request
Apr 3, 2022
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 12, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 12, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 12, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 14, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 15, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 17, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 17, 2024
shiftkey
added a commit
that referenced
this pull request
Sep 2, 2024
shiftkey
added a commit
that referenced
this pull request
Sep 2, 2024
shiftkey
added a commit
that referenced
this pull request
Oct 30, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 8, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 8, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 8, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 8, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 8, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #559
Thanks to @sarim for identifying the root cause.
The bit that I'd forgotten as part of this is that static assets need to be defined in a platform-specific subdirectory to be included as part of the app package -
app/static/win32
for Windows,app/static/darwin
for macOS andapp/static/linux
for Linux.This is the relevant code that does the actual copying:
desktop/script/build.ts
Lines 253 to 255 in c7c2cf6
app/static/logos
is only used at packaging time, which is why things were working sometimes.I also found out that the
icon
option forelectron-packager
is not supported on Linux, so I've updated that area to be clearer.