Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmify #86

Merged
merged 29 commits into from
Jan 30, 2025
Merged

wasmify #86

merged 29 commits into from
Jan 30, 2025

Conversation

shekohex
Copy link
Owner

@shekohex shekohex commented Mar 4, 2024

No description provided.

@shekohex shekohex requested a review from Copilot December 6, 2024 12:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 96 out of 111 changed files in this pull request and generated 1 suggestion.

Files not reviewed (15)
  • .vscode/settings.json: Language not supported
  • crates/db/src/portal.rs: Evaluated as low risk
  • crates/db/src/npc.rs: Evaluated as low risk
  • crates/db/src/map.rs: Evaluated as low risk
  • crates/db/src/character.rs: Evaluated as low risk
  • .cargo/config.toml: Evaluated as low risk
  • crates/db/src/account.rs: Evaluated as low risk
  • crates/codec/src/lib.rs: Evaluated as low risk
  • crates/crypto/src/lib.rs: Evaluated as low risk
  • crates/db/src/error.rs: Evaluated as low risk
  • crates/crypto/src/cq_cipher.rs: Evaluated as low risk
  • crates/crypto/src/tq_cipher.rs: Evaluated as low risk
  • crates/db/Cargo.toml: Evaluated as low risk
  • crates/bindings/.cargo/config.toml: Evaluated as low risk
  • Cargo.toml: Evaluated as low risk
Comments skipped due to low confidence (2)

crates/crypto/src/rc5.rs:82

  • The rotl function should be a regular function instead of const fn as it is not used in a constant context.
const fn rotl(value: u32, count: u32) -> u32 {

crates/crypto/src/rc5.rs:88

  • The rotr function should be a regular function instead of const fn as it is not used in a constant context.
const fn rotr(value: u32, count: u32) -> u32 {

crates/crypto/src/rc5.rs Outdated Show resolved Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@shekohex shekohex marked this pull request as ready for review January 30, 2025 12:47
@shekohex shekohex merged commit 8fbebc1 into master Jan 30, 2025
0 of 2 checks passed
@shekohex shekohex deleted the wasm branch January 30, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant