Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #15

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Refactor #15

merged 1 commit into from
Jan 27, 2025

Conversation

shawntoffel
Copy link
Owner

@shawntoffel shawntoffel commented Jan 27, 2025

  • Cleaned up structure & added comments.
  • Generate events after the count is complete rather than during.
  • Added report writing: result.Detail.WriteReport(io.Writer)
  • Removed election dependency.
  • Simplified interface:

Old:

m := meekstv.NewMeekStv()
m.Initialize(config)
result, err := m.Count()

New:

 result, err := meekstv.Count(config)

@shawntoffel shawntoffel self-assigned this Jan 27, 2025
@shawntoffel shawntoffel merged commit bb42f5b into master Jan 27, 2025
2 checks passed
@shawntoffel shawntoffel deleted the refactor branch January 27, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant