Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix suffix tree #239

Merged
merged 1 commit into from
Aug 15, 2020
Merged

fix suffix tree #239

merged 1 commit into from
Aug 15, 2020

Conversation

wzv5
Copy link
Contributor

@wzv5 wzv5 commented Aug 10, 2020

issue:
When insert abc.com and 1.abc.com, abc.com will not be matched.

Add an final flag to the tree to solve this problem.

issue:
When insert abc.com and 1.abc.com, abc.com will not be matched.

Add an final flag to the tree to solve this problem.
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #239 into master will increase coverage by 6.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   49.84%   55.97%   +6.12%     
==========================================
  Files          13       13              
  Lines         660      661       +1     
==========================================
+ Hits          329      370      +41     
+ Misses        283      241      -42     
- Partials       48       50       +2     
Impacted Files Coverage Δ
core/matcher/suffix/tree.go 87.23% <100.00%> (+87.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c127b...516c5fc. Read the comment docs.

@shawn1m shawn1m merged commit 5542834 into shawn1m:master Aug 15, 2020
@shawn1m
Copy link
Owner

shawn1m commented Aug 15, 2020

Merged. Thanks!

@wzv5 wzv5 deleted the fix-suffix-tree branch August 15, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants