Merge remote-tracking branch 'origin/fetch-title'

sharunkumar · Oct 28, 2023 · 5a1790d · 5a1790d
2 parents 696dfcc + 2b6b525
commit 5a1790d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/src/features/post/new/PostEditorRoot.tsx b/src/features/post/new/PostEditorRoot.tsx
@@ -331,19 +331,23 @@ export default function PostEditorRoot({
   }
 
   async function fetchPostTitle() {
+    let metadata;
+
     try {
-      const { metadata } = await client.getSiteMetadata({
+      ({ metadata } = await client.getSiteMetadata({
         url,
-      });
-
-      if (metadata.title) {
-        setTitle(metadata.title?.slice(0, MAX_TITLE_LENGTH));
-      } else {
-        presentToast(problemFetchingTitle);
-      }
+      }));
     } catch (error) {
       presentToast(problemFetchingTitle);
+      throw error;
     }
+
+    if (!metadata.title) {
+      presentToast(problemFetchingTitle);
+      return;
+    }
+
+    setTitle(metadata.title?.slice(0, MAX_TITLE_LENGTH));
   }
 
   return (

diff --git a/src/helpers/toastMessages.ts b/src/helpers/toastMessages.ts
@@ -36,7 +36,7 @@ export const problemBlockingUser: AppToastOptions = {
 
 export const problemFetchingTitle: AppToastOptions = {
   message: "Unable to fetch title",
-  color: "danger",
+  color: "warning",
 };
 
 export function buildBlocked(