Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toast warnings on job retries #11

Merged
merged 5 commits into from
Feb 7, 2019
Merged

toast warnings on job retries #11

merged 5 commits into from
Feb 7, 2019

Conversation

ultraschuppi
Copy link
Member

  • show warnings every time a job is retried because of an exception
  • added sticky toast into the toastservice
  • added stickyness to some toast-events (e.g. download finally failed)

@ultraschuppi ultraschuppi mentioned this pull request Feb 7, 2019
Closed
@ultraschuppi
79e9a65 
moved showWarning to be a protected function within JobItem
@ColRad ColRad merged commit 42fa691 into master Feb 7, 2019
@ultraschuppi ultraschuppi deleted the #2-toastsForRetries branch February 7, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColRad ColRad ColRad left review comments

@urbanisierung urbanisierung Awaiting requested review from urbanisierung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ultraschuppi @ColRad