Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove douplicated page schema #1355

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

Gnito
Copy link
Contributor

@Gnito Gnito commented Aug 23, 2020

This removes duplicate schema (LD+JSON) script element from the DOM. CSR removes #page-schema from DOM if one exists. We use "id" attribute to identify correct schema script (multiple schemas should be OK for search engines).

Note: Google schema debugger does notice that there was one script coming from SSR and CSR adds another on initial page load.

@Gnito
Copy link
Contributor Author

Gnito commented Aug 23, 2020

This is a fix to issue #1338

@Gnito Gnito requested a review from OtterleyW August 23, 2020 20:35
@Gnito Gnito temporarily deployed to ftw-daily-poppins August 24, 2020 09:41 Inactive
Copy link
Contributor

@OtterleyW OtterleyW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Gnito Gnito merged commit dbf21d4 into master Aug 24, 2020
@Gnito Gnito deleted the fix-douplicated-page-schema branch August 24, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants