Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove create dtxsid by api #995

Merged
merged 25 commits into from
Mar 13, 2024
Merged

Remove create dtxsid by api #995

merged 25 commits into from
Mar 13, 2024

Conversation

dannypeterson
Copy link
Contributor

@dannypeterson dannypeterson commented Feb 20, 2024

Removes the ability to create DSSTox model through Epi Exposure API, as validation does not properly pull data. create method was added to DSSTox viewset which properly populates ccte content correctly for dtxisd. Modified and created tests.

@shapiromatron shapiromatron changed the base branch from main to replace-vcr-with-recording February 20, 2024 19:43
@shapiromatron shapiromatron marked this pull request as draft February 20, 2024 20:26
Base automatically changed from replace-vcr-with-recording to main February 23, 2024 04:40
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think you need to fix your vscode so it stops adding trailing commas; its hard to review b/c there are a bunch of unintended formatting changes.

I think we need a test where the dtxsid is invalid, like dtxsid0000000000 or something like that?

@dannypeterson dannypeterson marked this pull request as ready for review February 23, 2024 21:40
@shapiromatron shapiromatron self-assigned this Feb 27, 2024
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I made a few edits including a permissions change, but nothing major other than that - nice job!

@shapiromatron shapiromatron merged commit 8756462 into main Mar 13, 2024
6 checks passed
@shapiromatron shapiromatron deleted the remove-create-dtxsid-by-api branch March 13, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants