-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data pivot - calculated columns #991
Conversation
This reverts commit 29ad230.
…ron/hawc into dp-calculated-columns
@shapiromatron Ready for review!
|
@shapiromatron I have updated the parser language so that it can handle nested ternaries correctly; an example is in the test suite. I also added the
There is also an npm script that generates the
This PR is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rabstejnek I think you have to do the final review b/c I opened the PR initially, but I think this is great and will be a I think a highlight of our next release.
I made the following edits:
- 782feb4 fix docs (facepalm) (17 seconds ago) {Andy Shapiro}
- 19433ec add some text to describe how to use (50 minutes ago) {Andy Shapiro}
- b3d9072 fix test case (80 minutes ago) {Andy Shapiro}
- 3be80db add round (2 hours ago) {Andy Shapiro}
- 99aef96 add "to_right" to fixture; should have added in data pivot - add columns to the right of the figure #987 (3 hours ago) {Andy Shapiro}
- 9d17e63 use latest peggy version (6 hours ago) {Andy Shapiro}
- 11883b8 fix migration conflict (6 hours ago) {Andy Shapiro}
If you're ok w/ the changes, please approve.
To document our sidebar chats, but it'd be good to get this in use initially to determine the need first:
- we may change
${}
toshow()
in the future - we may rewrite the ternary expression
a?b:c
toifelse(a,b,c)
Enable the ability to add calculated fields in a data pivot whose output is derived from other fields in the dataset. Coupled with #987, this allows for users to mix and match columns to present to the right of a data pivot using information presented in the visual.
For example:
${endpoint name} (${response units}) @ ${observation time text}
match(dose,0)?-:${dose} ${dose units}
${response} ± round(stdev,2) (round(percent control mean,1)%)
Renders: