fix automatic scrolling with htmx requests #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Changes look good, but I think we should refactor the code to put most of this into the HAWCUtils.js file so we can reuse in other HTMX places. The same will be true on the epiv2 and eco forms, and TBH, they're used a lot more than the workflow edit forms, so we should move the goodness over there too.
|
@caseyhans is this one ready for re-review? |
# Conflicts: # hawc/apps/eco/templates/eco/design_update.html # hawc/apps/epiv2/templates/epiv2/design_update.html
shapiromatron
approved these changes
Feb 27, 2024
|
@shapiromatron had to add back delete for workflow edit rows, or the create button scroll doesn't work after the first time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the automatic scrolling on the workflows list page while CRUDing, and adds an animation for smoothness.
Previously, updating or creating a workflow would snap focus to the name input field of the first form present on the page (which creates a bug if multiple forms are present). After cancelling or saving the form, users would be left looking at the page footer, since the form is so long and the save/cancel buttons are at the bottom. This PR saves the scroll position before a form is brought onto the page and then reinstates that scroll position once form operations are complete.