Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve boolean icon #974

Merged
merged 2 commits into from
Feb 7, 2024
Merged

improve boolean icon #974

merged 2 commits into from
Feb 7, 2024

Conversation

caseyhans
Copy link
Collaborator

Change the symbol for 'author contacted' from a minus to a times. This changes the symbol in other locations too, but it's prety minor.

image
image

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yes, this is a much better icon. I searched the codebase and saw it was used in some other places too - do you think it should be replaced in these cases too, or is there ever a case for the minus?

image

@caseyhans
Copy link
Collaborator Author

Ahh yes, this is a much better icon. I searched the codebase and saw it was used in some other places too - do you think it should be replaced in these cases too, or is there ever a case for the minus?

image

Most of these cases are using minus as a minimize symbol, which is a good use case for that symbol.
The exception is in the study list, where minus indicates that a study is not of a particular type (i.e., bioassay, epidemiology, etc.). I tried swapping for the times symbol here but I felt that the similarity to the check mark made it harder to determine the study type(s) at a glance.

Example:
image

image

@shapiromatron
Copy link
Owner

shapiromatron commented Feb 7, 2024

Ahh yes, this is a much better icon. I searched the codebase and saw it was used in some other places too - do you think it should be replaced in these cases too, or is there ever a case for the minus?

Most of these cases are using minus as a minimize symbol, which is a good use case for that symbol. The exception is in the study list, where minus indicates that a study is not of a particular type (i.e., bioassay, epidemiology, etc.). I tried swapping for the times symbol here but I felt that the similarity to the check mark made it harder to determine the study type(s) at a glance.

Completely agree. Nice job!

@shapiromatron shapiromatron merged commit fecacae into main Feb 7, 2024
3 checks passed
@shapiromatron shapiromatron deleted the change-minus-times branch February 7, 2024 02:21
@shapiromatron shapiromatron changed the title change minus to times improve boolean icon Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants