Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make searches reflect expanded prop type #953

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Nov 21, 2023

We received feedback from some users that the reference search/import information can be useful during tagging. Therefore, we added back the full search/import list on the detail view of a reference (on reference detail pages as well as reference tagging).

On list views, the collapsed button group is shown instead.

Tagging/reference detail view:
image

List view (see the source button in the actions menu):
image

Copy link
Collaborator

@caseyhans caseyhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the label in favor of icons (see updated PR description). Good to merge if you're OK with the change!

This reverts commit f8f28a7.
@shapiromatron
Copy link
Owner Author

shapiromatron commented Nov 29, 2023

Removed the label in favor of icons (see updated PR description). Good to merge if you're OK with the change!

Thanks for the review! I ended up reverting the change; scientists requested restoring the prior UI.

@shapiromatron shapiromatron merged commit be7035f into main Nov 29, 2023
@shapiromatron shapiromatron deleted the reference-search-expanded branch November 29, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants