Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated epa styles.css file #945

Merged
merged 11 commits into from
Nov 15, 2023
Merged

updated epa styles.css file #945

merged 11 commits into from
Nov 15, 2023

Conversation

dannypeterson
Copy link
Contributor

@dannypeterson dannypeterson commented Oct 31, 2023

Updated the epa css file to comply with EPA standards and procedures found here. Main changes:

  • updating the EPA header colors
  • removing transition when hovering over header links to comply with updated EPA site
  • overwriting transitions applied to every element in epa-hawc.css
  • Updated docs to explain updating future epa styles
    image

@dannypeterson dannypeterson marked this pull request as ready for review October 31, 2023 15:25
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dannypeterson, sorry I totally missed one important thing. We'll want to make no edits at all to this file so we can just drop it in; and then make edits to static/css/epa-hawc.css. That file gets loaded after and can update as needed; Pinging @caseyhans ; he can help translate these revisions if needed.

@dannypeterson dannypeterson deleted the update-EPA-template branch October 31, 2023 17:43
@dannypeterson dannypeterson restored the update-EPA-template branch October 31, 2023 18:00
@dannypeterson dannypeterson reopened this Oct 31, 2023
@dannypeterson dannypeterson marked this pull request as draft October 31, 2023 18:01
@dannypeterson dannypeterson marked this pull request as ready for review October 31, 2023 19:30
@shapiromatron shapiromatron self-requested a review November 1, 2023 03:00
@shapiromatron
Copy link
Owner

shapiromatron commented Nov 13, 2023

ok to merge @caseyhans ? I'm fixing links in the footer.

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I had to make three changes:

  • 8bfe6bf fix usa-banner caret
  • d1c7c74 update header search button and main menu when collapsed
  • e0d4dde update footer links

I compared the header/footer to epa.gov and found that that there were a number of differences. Hopefully the are explained well in the commits above.

@caseyhans - requesting your review please; ok to merge from my end.
@dannypeterson - fyi - had to make some additional edits b/c the header/footer looked pretty different. Let me know if you'd like me to walk you through the edits tomorrow.

@shapiromatron shapiromatron merged commit 4b07d58 into main Nov 15, 2023
@shapiromatron shapiromatron deleted the update-EPA-template branch November 15, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants