-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual study prefilters #939
Conversation
…, added study prefilter for rob visuals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Danny. I ran a number of notebooks and found that there were 2 visuals that changed but they weren't public, and I don't think they were really ready for prime time, so changes look good with data.
I made a number of minor edits, please scan the commits and if you're ok, feel free to merge!
- 1169f52 improve docstrings and type annotations (2 hours ago) {Andy Shapiro}
- d4b939f fix error in filter lookup (2 hours ago) {Andy Shapiro}
- acfc8ed filter study lists to only show by data type (3 hours ago) {Andy Shapiro}
- cadb1fd add invitro to barchart options (20 hours ago) {Andy Shapiro}
- e3d17ba ruff format (21 hours ago) {Andy Shapiro}
- 779cf09 Merge branch 'main' into study-prefilters (21 hours ago) {Andy Shapiro}
Added visual prefilters at the study level for RoB visuals instead of working backwards from endpoint prefilters. This also opened the way for different evidence types for the RoB visuals: bioassay (the default), epidemiology, and in vitro.
This process has been generalized enough that other evidence types can be added to the other visuals pretty easily, and also will make transitioning data pivots into visuals easier in the future.
Also, some refactoring was done on the prefilters by separating them into modules based on their app; this was necessary since the module that we had all of the prefilters in was becoming bloated.