Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dich % change calc #909

Merged
merged 6 commits into from
Sep 29, 2023
Merged

added dich % change calc #909

merged 6 commits into from
Sep 29, 2023

Conversation

dannypeterson
Copy link
Contributor

No description provided.

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change to how change is calculated; we have to normalize to fraction incidence instead of raw unnormalized counts

@dannypeterson
Copy link
Contributor Author

percent change calc
Updated the calc to ((i1/n1)-(i0/n0))/(i0/n0), but the calculations seem weird... (0.7 - 0.1) / (0.1) = 0.6/0.1 = 6 so not sure why we are getting a 5.99 float. Also shouldnt the result be 0.6 instead bc we multiply by 100 for % change

@shapiromatron
Copy link
Owner

percent change calc Updated the calc to ((i1/n1)-(i0/n0))/(i0/n0), but the calculations seem weird... (0.7 - 0.1) / (0.1) = 0.6/0.1 = 6 so not sure why we are getting a 5.99 float. Also shouldnt the result be 0.6 instead bc we multiply by 100 for % change

That seems correct! I think it's a 600% percent chagne relative to control

@dannypeterson dannypeterson merged commit 26414d1 into main Sep 29, 2023
@dannypeterson dannypeterson deleted the dichotomous-change-calcs branch September 29, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants