Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated old FlatExport to use new helper method #873

Merged
merged 3 commits into from
Aug 29, 2023
Merged

updated old FlatExport to use new helper method #873

merged 3 commits into from
Aug 29, 2023

Conversation

dannypeterson
Copy link
Contributor

converted export = FlatExport(df, filename) to use new FlatExport.api_response(df, filename) helper method for more DRY code

@dannypeterson dannypeterson marked this pull request as ready for review August 3, 2023 14:54
shapiromatron
shapiromatron approved these changes Aug 28, 2023
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shapiromatron shapiromatron merged commit a6f5420 into main Aug 29, 2023
@shapiromatron shapiromatron deleted the new-flat-export-method branch August 29, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannypeterson @shapiromatron