Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap log form to inline #872

Merged
merged 7 commits into from
Aug 29, 2023
Merged

swap log form to inline #872

merged 7 commits into from
Aug 29, 2023

Conversation

caseyhans
Copy link
Collaborator

@caseyhans caseyhans commented Aug 2, 2023 •
edited
Loading

Swap log filter form to a filterset, with expandable inline UI

before:
image

after:
image

@caseyhans caseyhans requested a review from shapiromatron August 2, 2023 15:46
@caseyhans caseyhans mentioned this pull request Aug 2, 2023
Merged
shapiromatron
shapiromatron approved these changes Aug 28, 2023
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; nice find

@caseyhans caseyhans merged commit 3770c92 into main Aug 29, 2023
@caseyhans caseyhans deleted the log-filter-inline branch August 29, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caseyhans @shapiromatron