Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added header to Update Assessment Value page #831

Merged
merged 7 commits into from
May 31, 2023
Merged

added header to Update Assessment Value page #831

merged 7 commits into from
May 31, 2023

Conversation

dannypeterson
Copy link
Contributor

@dannypeterson dannypeterson commented May 30, 2023 •
edited
Loading

assessment value header

@dannypeterson dannypeterson marked this pull request as ready for review May 30, 2023 15:59
shapiromatron
shapiromatron requested changes May 30, 2023
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but instead of adding to the template; can we add to the form instead? If may be better to just make it more generic "Create Assessment Value" instead of including the assessment info; that's available in the sidebar and breadcrumbs.

shapiromatron
shapiromatron approved these changes May 31, 2023
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Made a few more edits for related changes (instead of making additional jira cards) - if you're ok with the changes, feel free to merge.

@dannypeterson dannypeterson merged commit 51eb29c into main May 31, 2023
@dannypeterson dannypeterson deleted the assessment-value-header branch May 31, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannypeterson @shapiromatron