Inline filter forms #817
Merged
Inline filter forms #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@casey1173 I'll review today - would you like to make the edits to use the updated version beforehand? |
yeah sure! |
rabstejnek
approved these changes
May 25, 2023
shapiromatron
approved these changes
May 30, 2023
| @@ -102,6 +102,16 @@ def get_queryset(self): | |||
| .order_by("study__short_citation", "type") | |||
| ) | |||
|
|
|||
| def get_filterset_form_kwargs(self): | |||
There was a problem hiding this comment.
nice example of the benefits of they dynamic fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds inline and expandable filter forms, lifted from previous work on LLR/HERO.
Before:
Collapsed
Expanded
After:
Collapsed
Expanded
