Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessment values update #792

Merged
merged 16 commits into from
May 9, 2023
Merged

Assessment values update #792

merged 16 commits into from
May 9, 2023

Conversation

munnsmunns
Copy link
Collaborator

@munnsmunns munnsmunns commented Feb 27, 2023

New ADAF popover:
image
image

Changes to fields based on scientist feedback:

  • Change Species studied field to "Species and strain studied", and change to a text autocomplete field
  • Change name of duration to Value duration
  • Add help text to describe ADAF reasoning, e.g., supporting text about mutagenic mode of action    -"If checked, describe ADAF reasoning in the comment field, e.g., the chemical is carcinogenic by a mutagenic mode of action."
  • Assessment page, values table column order:    -eval type, health effect, val type, duration, value, POD type, POD, uncertainty factor, confidence
  • Change "value confidence" to "Confidence"
  • Add icon next to confidence with help text "confidence in toxicity value"
  • Update help text in value editing form for confidence to "Confidence in toxicity value"

@munnsmunns munnsmunns changed the base branch from main to next February 27, 2023 22:21
@munnsmunns munnsmunns marked this pull request as ready for review March 1, 2023 15:21
@munnsmunns munnsmunns requested a review from shapiromatron March 1, 2023 15:45
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some relatively minor changes; I may take this over so you can stay focused on the current work and turn it back to you after changes are done - is that ok?

@shapiromatron shapiromatron changed the base branch from next to main March 19, 2023 00:50
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; I made a bunch of text updates and some form layouts on other assessment things, but happy to get this one merged in.

@shapiromatron shapiromatron merged commit 06e2448 into main May 9, 2023
@shapiromatron shapiromatron deleted the assessment-values-update branch May 9, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants