Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eco form review fixes #791

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Eco form review fixes #791

merged 1 commit into from
Feb 27, 2023

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Feb 27, 2023 •
edited
Loading

A few additional fixes from a review of trying the forms out:

  • Update default ordering for eco results
  • Remove the unique-restraint for the sort value; I was having issues saving content with it
  • When adding results, filter list of available causes and effects to only show those present for the selected study (instead of all possible values)

@shapiromatron shapiromatron changed the base branch from main to next February 27, 2023 18:54
@shapiromatron shapiromatron changed the title Eco fixes from form review Eco form review fixes Feb 27, 2023
caseyhans
caseyhans approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@caseyhans caseyhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shapiromatron shapiromatron merged commit a04807b into next Feb 27, 2023
@shapiromatron shapiromatron deleted the eco-fixes branch February 27, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyhans caseyhans caseyhans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shapiromatron @caseyhans