Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix - fix duplicate rows when filtering on ROB owners #782

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Jan 30, 2023

Previously, when filtering a study, if a user conducted both an individual and final review, the row would be shown twice when filtering on a user. Adding distinct fixes. We cannot add the filterset filter directly, since we're overriding the queryset being used.

Fixes duplication here:
image

  • rob/assessment/:id/study-assignments/
  • rob/assessment/:id/study-assignments/update/

@shapiromatron shapiromatron changed the title hotfix - add distinct to assigned_user; user can have multiple review… hotfix - fix duplicate rows when filtering on ROB owners Jan 30, 2023
@shapiromatron shapiromatron marked this pull request as ready for review January 30, 2023 23:33
@shapiromatron shapiromatron merged commit 1f81b15 into main Feb 3, 2023
@shapiromatron shapiromatron deleted the distinct-rob-filter branch February 3, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants