hotfix - fix cookie vs token based client sessions #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression from #762.
We added the ability to login a request via the
/myuser/api/validate-token/endpoint. This can be useful with browsing the non-API website, but it breaks functionality on the API sdide because CSRF tokens are required (since it finds a valid django session, it uses that first, before falling back to tokens). While inconvenient in the context of this PR, this is desired behavior, (that is, checking session before token).This PR adds a new optional query param to log the user in with a django session if specified, and the corresponding client parameter to specify it. By default, it's disabled and API token based sessions will be used.